[U-Boot-Users] [PATCH, RFC] NAND: Scan 2nd page for badblock markers

[Guennadi Liakhovetski]

On Wed, 30 Jul 2008, Scott Wood wrote:

> On Wed, Jul 30, 2008 at 02:31:07PM +0200, Guennadi Liakhovetski wrote:
> >  	/* 2 Gigabit */
> > -	{"NAND 256MiB 1,8V 8-bit",	0xAA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_NO_AUTOINCR},
> > -	{"NAND 256MiB 3,3V 8-bit",	0xDA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_NO_AUTOINCR},
> > -	{"NAND 256MiB 1,8V 16-bit",	0xBA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_BUSWIDTH_16 | NAND_NO_AUTOINCR},
> > -	{"NAND 256MiB 3,3V 16-bit",	0xCA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_BUSWIDTH_16 | NAND_NO_AUTOINCR},
> > +	{"NAND 256MiB 1,8V 8-bit",	0xAA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_NO_AUTOINCR |
> > +							 NAND_BBT_SCAN2NDPAGE},
> > +	{"NAND 256MiB 3,3V 8-bit",	0xDA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_NO_AUTOINCR |
> > +							 NAND_BBT_SCAN2NDPAGE},
> > +	{"NAND 256MiB 1,8V 16-bit",	0xBA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_BUSWIDTH_16 | NAND_NO_AUTOINCR |
> > +							 NAND_BBT_SCAN2NDPAGE},
> > +	{"NAND 256MiB 3,3V 16-bit",	0xCA, 0, 256, 0, NAND_SAMSUNG_LP_OPTIONS | NAND_BUSWIDTH_16 | NAND_NO_AUTOINCR |
> > +							 NAND_BBT_SCAN2NDPAGE},
> >  
> 
> NAND_BBT_SCAN2NDPAGE is a BBT option, not a NAND option.  You can't
> combine them like this.

You're right of course. So, one should check for device ID code and set 
the flag in the badblock_pattern.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de