[U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

Wolfgang Denk wd at denx.de
Thu Jul 31 10:33:39 CEST 2008


In message <5BF78BCE8D9BF14A83F836BD9E3916BA23C1B7 at blrms.slti.sanyo.co.in> you wrote:
> Hi,
> 
> >> @@ -50,8 +50,7 @@ static ulong lastdec;  int timer_init (void)  {
> >>   *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20
> >> TimerLoad */
> >^^^^^^^^^^^^^
> >> - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD; /*=20
> >> TimerValue */
> >^^^^^^^^^^^^^
> >
> >Your patch is line-wrapped and cannot be applied.
> 
> I Checked the Original Source File & found this.
> 
> 	*(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD;
> /* TimerLoad */  ---> This line ends @ Column 80
> 	*(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD;
> /* TimerValue */  ---> This line ends @ Column 81
> 
> I just removed the Second Line since it was Invalid.
>
> I am really sorry for troubling but i have little issue finding the
> mistake.
> Now in order to remove this, kindly let me know what i have to do.

Please resubmit your patch, without line wrapping.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Shakespeare's Law of Prototyping: (Hamlet III, iv, 156-160)
        O, throw away the worser part of it,
        And live the purer with the other half.




More information about the U-Boot mailing list