[U-Boot-Users] [PATCH] bdinfo not showing correct info about memory size

[Wolfgang Denk]

In message <200807301413.32008.sr at denx.de> you wrote:
>
> > Given the fact that print_lnum() unconditionally takes a u64 arg  and
> > unconditionally  uses  a  %llX  format,  I  thinkwe shoudl either fix
> > print_lnum() for non-64bit cases, or drop  the  CFG_64BIT_VSPRINTF  /
> > CFG_64BIT_STRTOUL options completely.
> 
> Personally, I'm voting for dropping the options completely and enabling the 
> 64bit support unconditionally. I took me some time a few days ago to figure 
> out that this support was *not* enabled by default.

Well, it adds some 2.2 kB of code size for all ssytems - even those
who have zero benefit from it.

My personal preference would be to fix print_lnum() to take for
example a phys_size_t argument instead of u64.

I guess we need an #ifdef for the %llX (versus %lX) format  then  (or
does anybody know of a clever way to avoid this, maybe something like
the %zu we used to fix the size_t issues? )

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No more blah, blah, blah!
	-- Kirk, "Miri", stardate 2713.6