[U-Boot-Users] [PATCH] nand_spl: clean up Makefile

[Wolfgang Denk]

In message <1217510106-9380-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
> need Scott Wood patch  * NAND: $(obj)-qualify ecc.h in kilauea NAND boot Makefile.

This has been in mainline for some time...

> @@ -53,54 +60,54 @@ $(nandobj)u-boot-spl.bin:	$(nandobj)u-boot-spl
>  $(nandobj)u-boot-spl:	$(OBJS)
>  	cd $(LNDIR) && $(LD) $(LDFLAGS) $(__OBJS) \
>  		-Map $(nandobj)u-boot-spl.map \
> -		-o $(nandobj)u-boot-spl
> +		-o $@

If you do this, you should also change "$(nandobj)u-boot-spl.map"
into "$@.map" (and put both on one line), I think.

> --- a/nand_spl/board/amcc/canyonlands/Makefile
> +++ b/nand_spl/board/amcc/canyonlands/Makefile
> @@ -29,9 +29,9 @@ LDFLAGS	= -Bstatic -T $(LDSCRIPT) -Ttext $(TEXT_BASE) $(PLATFORM_LDFLAGS)
>  AFLAGS	+= -DCONFIG_NAND_SPL
>  CFLAGS	+= -DCONFIG_NAND_SPL
>  
> -SOBJS	:= start.o
> -SOBJS	+= init.o
> +SOBJS	:= init.o
>  SOBJS	+= resetvec.o
> +SOBJS	+= start.o
>  COBJS	:= ddr2_fixed.o
>  COBJS	+= nand_boot.o
>  COBJS	+= nand_ecc.o

I am not sure if changing the order of the object files is a good idea
here. Are you absolutley sure that start.o is not required to come first?

[Both comments apply to all the boards you touched, of course.]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fascinating, a totally parochial attitude.
	-- Spock, "Metamorphosis", stardate 3219.8