[U-Boot-Users] [PATCH 3/7] ARM: Add arm1176 core with s3c6400 SoC

[Wolfgang Denk]

In message <Pine.LNX.4.64.0807311242440.4832 at axis700.grange> you wrote:
> This is a port of s3c6400 sources by Samsung from u-boot-1.1.6.
> 
> Signed-off-by: Guennadi Liakhovetski <lg at denx.de>

Coding style errors: indentation by space instead of TAB;

...
> +/* * reset the cpu by setting up the watchdog timer and let him time out */
> +void reset_cpu (ulong ignored)
> +{
> +	printf("reset... \n\n\n");
> +	SW_RST_REG = 0x6400;
> +	/* loop forever and wait for reset to happen */
> +	while (1)
> +	{
> +		if (serial_tstc())
> +		{
> +			serial_getc();
> +			break;
> +		}
> +	}

Incorrect brace style.

...
> diff --git a/cpu/arm1176/s3c64xx/Makefile b/cpu/arm1176/s3c64xx/Makefile
> new file mode 100644
> index 0000000..0a1201d
> --- /dev/null
> +++ b/cpu/arm1176/s3c64xx/Makefile
> @@ -0,0 +1,46 @@
...
> +include $(TOPDIR)/config.mk
> +
> +LIB	= $(obj)lib$(SOC).a
> +
> +OBJS	= interrupts.o
> +#OBJS	= nand_cp.o serial.o usb_ohci.o interrupts.o nand.o
> +COBJS-$(CONFIG_S3C6400)	+= cpu_init.o speed.o
> +
> +OBJS	+= $(COBJS-y)
> +
> +all:	$(obj).depend $(START) $(LIB)
> +
> +$(LIB):	$(OBJS)
> +	$(AR) $(ARFLAGS) $@ $(OBJS)
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude .depend

Broken for out-of-tree building. This applies to all your  Makefiles,
I think.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Everything should be made as simple as possible, but not simpler."
                                                    - Albert Einstein