[U-Boot-Users] Pull request u-boot-blackfin.git

Wolfgang Denk wd at denx.de
Sun Jun 1 21:45:23 CEST 2008


In message <1212289153-5117-1-git-send-email-vapier at gentoo.org> you wrote:
> The following changes since commit 1f1554841a4c8e069d331176f0c3059fb2bb8280:
>   Wolfgang Denk (1):
>         Merge branch 'master' of /home/wd/git/u-boot/custodians
> 
> are available in the git repository at:
> 
>   git://www.denx.de/git/u-boot-blackfin.git review

What's that? I cannot make heads nor tails out of this.

If this was intended to be a pull request as the subject suggests,
then I see a few problems with that:

* minor problem: please provide stuff for pull requests in the
  "master" branch, as requested in
  http://www.denx.de/wiki/view/UBoot/CustodianGitTrees#BEFORE_Requesting_a_Pull

* Major problem: only changes should be used in custodian trees and
  submitted as part of a pull request, that had been submitted to the
  mailing list before, and for whioch at least no negative comments
  have been raised. But in this list here:

> Mike Frysinger (14):
>       Blackfin: make baud calculation more accurate
>       Blackfin: fix up UART status bit handling
>       Blackfin: fix up comment about CONFIG_BFIN_BOOT_MODE
>       Blackfin: punt unused page_descriptor_table_size definition
>       Blackfin: punt mem_init.h since it is no longer used
>       Blackfin: update cpu header definitions from latest Blackfin toolchain
>       Blackfin: punt unused BF533-STAMP definitions
>       Blackfin: resurrect BF533-STAMP video splash driver
>       Blackfin: touchup BF561-EZKIT board file
>       Blackfin: set default boot SPI CS for BF538/BF539
>       Blackfin: kill conversion warnings in async nand driver
>       Blackfin: tighten up post memory coding style
>       Blackfin: overhaul i2c driver
>       Blackfin: implement go/boote wrappers

I can only find 2 of these in the mailing list archives:

04/18 Mike Frysinger     [U-Boot-Users] [PATCH/review] Blackfin: overhaul i2c driver

Status: change request from Jean-Christophe Plagniol-Villard, no
feedback ever sent.

04/19 Mike Frysinger     [U-Boot-Users] [PATCH] Blackfin: implement go/boote wrappers

Status: rejected by me. Discussion stopped on 04/21.


This is not how you are supposed to work as a custodian.

Please stick to the rules.

Pull rejected.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When in doubt, mumble;   when in trouble, delegate;  when in  charge,
ponder.                                             -- James H. Boren




More information about the U-Boot mailing list