[U-Boot-Users] [PATCH/review] Blackfin: setup a sane default EBIU_SDBCTL for SDRAM controllers

[Mike Frysinger]

On Sunday 01 June 2008, Wolfgang Denk wrote:
> In message <200806011712.22201.vapier at gentoo.org> you wrote:
> > > This is pretty ugly code.
> >
> > little cruft on the backend makes the lives of board porters a lot
> > easier.
> >
> > > Why do you need the numeric values for CONFIG_MEM_SIZE
> >
> > because it gets used in many other places as a real value to create a
> > large number of sane defaults.  the bitmask EBSZ_# would not be usable.
>
> many... large number... well:
>
> $ find * -type f | xargs egrep CONFIG_MEM_SIZE | wc -l
> 17
>
> Sounds not *that* big a number to me.

and ?  it's clearly used in the raw form which the bitwise version is not 
applicable.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080601/8aa29920/attachment.pgp