[U-Boot-Users] [PATCH] soft_i2c: Pull SDA high before reading

Wolfgang Denk wd at denx.de
Thu Jun 5 00:06:18 CEST 2008


In message <1210928891-7971-1-git-send-email-haavard.skinnemoen at atmel.com> you wrote:
> Spotted by Dean Capindale.
> 
> Systems that support open-drain GPIO properly are allowed provide an
> empty I2C_TRISTATE define. However, this means that we need to be
> careful not to drive SDA low when the slave is expected to respond.
> 
> This patch adds a missing I2C_SDA(1) to read_byte() required to
> tristate the SDA line on systems that support open-drain GPIO.
> 
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>
> ---
>  common/soft_i2c.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"No proper program contains  an  indication  which  as  an  operator-
applied  occurrence  identifies an operator-defining occurrence which
as an indication-applied occurrence identifies an indication-defining
occurrence different from the one identified by the given  indication
as an indication-applied occurrence."               - ALGOL 68 Report




More information about the U-Boot mailing list