[U-Boot-Users] [PATCH V6] ARM: Add support for Lyrtech SFF-SDRboard (ARM926EJS)

[Hugo Villeneuve]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:33 Thu 05 Jun     , Hugo Villeneuve wrote:
>> ARM: This patch adds support for the Lyrtech SFF-SDR
>> board, based on the TI DaVinci architecture (ARM926EJS).
>> 
>> Changes between V5 and V6:
>>   -New email address for contributor.
>>   -Init of EMIF-A CS3 address space to load FPGA.
>>   -Dynamic parsing of MAC address in EEPROM.
>>   -Add boot delay of 5 sec.
>>   -Use NFS for Linux boot command.
>>   -Add relocate flag for command history.
>> 
>> Signed-off-by: Hugo Villeneuve <hugo.villeneuve at lyrtech.com>
>> Signed-off-by: Philip Balister, OpenSDR <philip at opensdr.com>
>> 
>> ---
>> 
>>  CREDITS                           |    5 +
>> +	/* Set the Bus Priority Register to appropriate value */
>> +	REG(VBPR) = 0x20; +
>> +	timer_init();
>> +
>> +	return(0);
>> +}
>> +
> 
> Is it possible that you add a documentiation about the EEPROM content?

Hi Jean-Christophe,
unfortunately, I don´t have the data structure of the EEPROM, only the
algorithym to parse it to find the MAC address.

>> +
>> +/*=======*/
>> +/* Board */
>> +/*=======*/
> If Possible use this kind of comment style
> /*
>  *
>  */

Ok, I fixed it.

>> +#define LINUX_BOOT_PARAM_ADDR	0x80000100
>> +#define CONFIG_CMDLINE_TAG
>> +#define CONFIG_SETUP_MEMORY_TAGS
>> +#define CONFIG_BOOTARGS			\
>> +	"mem=56M "			\
>> +	"console=ttyS0,115200n8 "	\
>> +	"root=/dev/nfs rw noinitrd ip=dhcp "	\
>> +	"nfsroot=${serverip}:/nfsroot/sffsdr "	\
>> +	"nwhwconf=device:eth0,hwaddr:${ethaddr}"
>> +#define CONFIG_BOOTCOMMAND	\
>> +	"nand read 87A00000 100000 300000;"	\
>> +	"bootelf 87A00000"
> Could you align it or I will do it when I'll apply the patch,
> If it's ok with you.

Since I´m not sure how you want it to be aligned, please go ahead
and do it when you apply the patch as you suggested.

I¬m sending updated patch after this mail.

Thank-you, Hugo V.

Hugo Villeneuve
Hardware developer | Concepteur matériel
Lyrtech
Phone/Tél. : (1) (418) 877-4644 #2395
Toll-free/Sans frais - Canada & USA : (1) (888) 922-4644 #2395
Fax/Téléc. : (1) (418) 877-7710
www.lyrtech.com
Infinite possibilities...TM