[U-Boot-Users] [PATCH 1/2] 83xx/85xx/86xx: factor out Freescale Localbus defines out of mpc83xx.h

[Wolfgang Grandegger]

Anton Vorontsov wrote:
> On Wed, May 28, 2008 at 12:21:26PM -0500, Kim Phillips wrote:
>> On Wed, 28 May 2008 18:20:15 +0400
>> Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
>>
>>> This patch moves Freescale Localbus defines out of mpc83xx.h, so we could
>>> use it on MPC85xx and MPC86xx processors.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
>>> ---
>>>  include/asm-ppc/fsl_lbc.h |  251 +++++++++++++++++++++++++++++++++++++++++++++
>>>  include/mpc83xx.h         |  234 +-----------------------------------------
>>>  include/mpc85xx.h         |    2 +
>>>  include/mpc86xx.h         |    2 +
>>>  4 files changed, 256 insertions(+), 233 deletions(-)
>>>  create mode 100644 include/asm-ppc/fsl_lbc.h
>>>
>> can we move the BRx_* and ORx_* left behind in mpc85xx.h also?
> 
> Yes, easily (because there is no single user).
> 
> The same is needed for mpc8xx.h and mpc8260.h (defines are almost
> the same, just few differences which needs some attention though).
> 
> But the bad news for mpc8xx and mpc8260 is that there are a lot of users
> of these defines. So this cleanup I'll leave for the "better times".
> 
> - - - -
> From: Anton Vorontsov <avorontsov at ru.mvista.com>
> Subject: 83xx/85xx: further localbus cleanups
> 
> Merge mpc85xx.h's LBC defines to fsl_lbc.h. Also, adopt ACS names
> from mpc85xx.h, so ACS_0b10 renamed to ACS_DIV4, ACS_0b11 to ACS_DIV2.
> 
> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
> ---
>  include/asm-ppc/fsl_lbc.h     |   17 +++++++++++++++--
>  include/configs/MPC8315ERDB.h |    2 +-
>  include/configs/MPC8349EMDS.h |    2 +-
>  include/configs/MPC8349ITX.h  |    4 ++--
>  include/configs/MPC8360EMDS.h |    2 +-
>  include/configs/MPC8360ERDK.h |    2 +-
>  include/configs/MPC837XEMDS.h |    2 +-
>  include/configs/TQM834x.h     |    2 +-
>  include/mpc85xx.h             |   35 -----------------------------------
>  9 files changed, 23 insertions(+), 45 deletions(-)

What is the status of these two patches? It would be nice if we could
apply them quickly because some pending patches already rely on (or
conflict with) them.

Thanks,

Wolfgang.