[U-Boot-Users] [PATCH v2] Move conditional compilation of MPC8XXX SPI driver to Makefile

[Haavard Skinnemoen]

Ben Warren <biggerbadderben at gmail.com> wrote:
> +/* Controller-specific definitions: */
> +
> +/* CONFIG_HARD_SPI triggers SPI bus initialization in PowerPC */
> +#ifdef CONFIG_MPC8XXX_SPI
> +# ifndef CONFIG_HARD_SPI
> +#  define CONFIG_HARD_SPI
> +# endif
> +#endif

Grumble. I'm really looking forward to that Kconfig system so we can
get rid of crap like this...it won't exactly become prettier as more
SPI drivers are added...

Btw, I wonder if the _real_ fix is to move the stuff in spi_init() into
spi_claim_bus() and just kill spi_init() altogether. This will match
the u-boot design requirement about not touching hardware you don't
intend to use a bit more closely.

But I can certainly understand that you want to keep the existing code
working before doing something like that.

Haavard