[U-Boot-Users] [PATCH] Add mechanisms for CPU and board-specific Ethernet initialization

[Shinya Kuribayashi]

Ben Warren wrote:
>>> @@ -165,6 +171,10 @@ int eth_initialize(bd_t *bis)
>>>  #if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
>>>       miiphy_init();
>>>  #endif
>>> +     /* Try CPU-specific initialization first.  If it fails or isn't
>>> +      * present, call the board-specific initialization */
>>> +     if (cpu_eth_init(bis) < 0 )
>> Nitpicking: No space before ")" please.
> Huh, don't know how I missed that one.
>>> +             board_eth_init(bis);
>> Shouldn't this be the other way around?
>>
>> +       if (board_eth_init(bis) < 0)
>> +               eth_eth_init(bis);
>>
>> So that the board init routine can "overwrite" the cpu init version.
>>
> Yeah, I think you're right.  If board_eth_init() exists, it gets
> highest priority.

Just wondered, does that mean we could only have either cpu_eth_init or
board_eth_init at a time?