[U-Boot-Users] [PATCH] Add PPC405 External Bus Controller (EBC) Register Field Mnemonics

Stefan Roese sr at denx.de
Thu Jun 12 11:58:35 CEST 2008


On Thursday 12 June 2008, Wolfgang Denk wrote:
> In message <C475A96A.FBA7%gerickson at nuovations.com> you wrote:
> > These are actually now used in cpu/ppc4xx/start.S and are probably
> > already included in the latest 4xx pull from Stefan. So, this patch might
> > be a no-op at this point.
>
> A slightly different version of this seems to  have  benn  pulled  in
> with  your  "ppc4xx:  Enable  Primordial  Stack for 40x and Unify ECC
> Handling" patch (c821b5f120be), but note that we have for example two
> different implementations of EBC_BXCR_BAS_ENCODE in  include/ppc405.h
> and  include/ppc440.h  -  the  include/ppc405.h was changed with your
> c821b5f120be commit, while the include/ppc440.h code  is  much  older
> (63153492 from 3 years ago).
>
> Please check that this is as intended.

We should consolidate these defines into one version. No need to have them 
defined multiple times, since the EBC IP core should be nearly identical on 
405 and 440 systems. Perhaps somebody else (Grant?) will find the time to do 
this soon. If not I'll add it to my list...

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================




More information about the U-Boot mailing list