[U-Boot-Users] [PATCH 1/2] AT572D940HF-EB Support v2 (SDHC support part 1)

[Haavard Skinnemoen]

On Thu, 12 Jun 2008 19:19:47 +0200
"Ulf Samuelsson" <ulf.samuelsson at atmel.com> wrote:

> Haavard Skinnemoen wrote:
> > It's a bit hard to see what your proposal is all about when you create
> > a new file instead of modifying the exising one...
> > 
> 
> If you want to see changes right now, 
> then just replace the existing file with the Diopsis file and do a diff.

The whole idea about e-mail review is that someone posts a patch and
someone else reviews it.

> > So how about we start by introducing a new drivers/mmc directory and
> > move the existing AVR32 driver there? After that, you can apply your
> > changes to it and send a patch which clearly shows the differences
> > from the old code. Don't worry about breaking AVR32 -- I'll help you
> > test it before it gets merged upstream.
> > 
> 
> Why not get the Diopsis support in first, and then do the merge afterwards.
> I do agree that they should be merged, but that does not mean
> that delaying the availability of Diopsis support in U-Boot is a good idea.

I disagree. Why do a half-assed job when you can do it properly?

Besides, the merge window is closed now, isn't it? So we have lots of
time to review and test things before the next merge window.

Haavard