[U-Boot-Users] [Patch 5/9]U-boot-V2:cmd: add I2C commands

Menon, Nishanth x0nishan at ti.com
Fri Jun 20 04:10:28 CEST 2008


Wolfgang,
> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de]
> Sent: Thursday, June 19, 2008 3:33 PM
> To: Menon, Nishanth
> Cc: Sascha Hauer; u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] [Patch 5/9]U-boot-V2:cmd: add I2C commands
>
> Please indent by TABs.
Is'nt checkpatch supposed to catch such issues?
I do get 10 warning all of the nature of:

WARNING: consider using strict_strtol in preference to simple_strtol
#1167: FILE: commands/i2c.c:1145:
+               vmask = simple_strtol(argv[flags + 6], &end, 0);

But there are no tab warnings. Since we don't have strict_strol, I have
Ignored this warning for u-boot v2.

Regards,
Nishanth Menon




More information about the U-Boot mailing list