[U-Boot-Users] [PATCH] Makefile: fix problem with out-of-tree builds introduced by 5013c09f

Detlev Zundel dzu at denx.de
Wed Mar 5 13:46:14 CET 2008


Hi Wolfgang,

> Commit 5013c09f (Makefile: cleanup "clean" target) introduced a
> problem for out-of-tree builds which caused "make clean" to fail.

This patch mixes whitespace cleanup with the actual logical change
making it unneccessary hard to read.

Can you please separate cosmetic from logical changes in the future?  I
would even have tried to split up the patch, but you already applied it,
so I have not much chance here :(

For things like this I *love* "git-add -i" in the meantime.  I cannot
stress enough how easy it is to split changes _after_ the actual editing
into separate commits.

Cheers
  Detlev

-- 
Markov does it in chains.
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de




More information about the U-Boot mailing list