[U-Boot-Users] [PATCH] mpc83xx: make dtb basename file references equal those of linux

[Wolfgang Denk]

In message <20080307122731.1ecaf291.kim.phillips at freescale.com> you wrote:
> the dts file basenames were updated in linux - this helps avoid
> inadvertently loading any old dtbs laying around.
> 
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> ---
>  include/configs/MPC832XEMDS.h |    2 +-
>  include/configs/MPC8360EMDS.h |    2 +-
>  include/configs/MPC837XEMDS.h |    2 +-
>  include/configs/MPC837XERDB.h |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h
> index 702b073..f32c4f7 100644
> --- a/include/configs/MPC832XEMDS.h
> +++ b/include/configs/MPC832XEMDS.h
> @@ -583,7 +583,7 @@
>     "ramdiskaddr=1000000\0"						\
>     "ramdiskfile=ramfs.83xx\0"						\
>     "fdtaddr=400000\0"							\
> -   "fdtfile=mpc832xemds.dtb\0"						\
> +   "fdtfile=mpc832x_mds.dtb\0"						\

I don't think this is a good idea. File names and board config  names
should  match  as  far  as  possible,  and  here is no good reason to
deviate from this rule.

I tend to NAK this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We are all agreed that your  theory  is  crazy.  The  question  which
divides  us  is  whether it is crazy enough to have a chance of being
correct. My own feeling is that it is not crazy enough.  - Niels Bohr