[U-Boot-Users] [PATCH] mpc83xx: make dtb basename file references equal those of linux

[Jerry Van Baren]

Kim Phillips wrote:
> On Fri, 07 Mar 2008 20:38:31 +0100
> Wolfgang Denk <wd at denx.de> wrote:
> 
>> In message <20080307122731.1ecaf291.kim.phillips at freescale.com> you wrote:
>>> the dts file basenames were updated in linux - this helps avoid
>>> inadvertently loading any old dtbs laying around.
>>>
>>> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
>>> ---
>>>  include/configs/MPC832XEMDS.h |    2 +-
>>>  include/configs/MPC8360EMDS.h |    2 +-
>>>  include/configs/MPC837XEMDS.h |    2 +-
>>>  include/configs/MPC837XERDB.h |    2 +-
>>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h
>>> index 702b073..f32c4f7 100644
>>> --- a/include/configs/MPC832XEMDS.h
>>> +++ b/include/configs/MPC832XEMDS.h
>>> @@ -583,7 +583,7 @@
>>>     "ramdiskaddr=1000000\0"						\
>>>     "ramdiskfile=ramfs.83xx\0"						\
>>>     "fdtaddr=400000\0"							\
>>> -   "fdtfile=mpc832xemds.dtb\0"						\
>>> +   "fdtfile=mpc832x_mds.dtb\0"						\
>> I don't think this is a good idea. File names and board config  names
>> should  match  as  far  as  possible,  and  here is no good reason to
>> deviate from this rule.
>>
>> I tend to NAK this.
> 
> but these are the filenames in linux' device tree directory -
> arch/powerpc/boot/dts, and I'm assuming people do something sane like
> dtc -I $file.dts -O $file.dtb.
> 
> are you suggesting we rename u-boot's config files too?
> 
> Kim

I'm with Kim & Timur on this one.  The kernel is in the driver's seat on 
the .dts, and thus the .dtb file names for these targets.

Best regards,
gvb