[U-Boot-Users] [PATCH] sh: Add Ethernet support for MPR2 board

[Mark Jonas]

Hi Ben,

>  Your intentions are good, but you have to know that there's no way this
>  driver is going into U-boot unless it meets the coding standards.  There
>  are many reasons for this policy, but suffice to say it just ain't gonna
>  happen.

OK, I somehow thought so but isn't there this clause in the U-Boot Readme:

"Source files originating from a different project (for example the
MTD subsystem) are generally exempt from these guidelines and are not
reformated to ease subsequent migration to newer versions of those
sources."

>  If you clean it up, we'll put it in.  Also, sending patches zipped up is
>  uncool.  Please send as inline text and break up logically if you need to.

Maybe I am uncool but I just obeyed the Readme:

"* Remember that there is a size limit of 40 kB per message on the
 u-boot-users mailing list. Compression may help."

IMHO I broke it up logically into two patches. One containing the mpr2
board code and one the Ethernet driver extension. The driver itself
does not make sense to add to U-Boot if nobody is using it. My changes
to the mpr2 board to add Ethernet support do not make sense without
the driver.

Is it worth the effort splitting this patch into two pieces without
adjusting the driver's formatting or should I really forget it?

Regards,
Mark