[U-Boot-Users] [RFC/PATCH] fix initdram / use of phys_addr_t

[Kumar Gala]

On Mar 12, 2008, at 1:40 PM, Wolfgang Denk wrote:

> Dear Kumar,
>
> in message <Pine.LNX. 
> 4.64.0803121037440.13065 at blarg.am.freescale.net> you wrote:
>>
>> The idea is that initdram() should really have returned a 'unsigned  
>> long'.
>> However if we are going to change everyone that has initdram I  
>> figure we
>> should make it return a phys_addr_t.
>
> Um, no, I don't think so.

would phys_size_t be better?

>> +phys_addr_t initdram(int board_type)
>> {
>> -	long dram_size = 0;
>> +	phys_addr_t dram_size = 0;
>
> No - initdram() does not return an address, it returns a size.

Sure, I understand it returns a size.  I was just using phys_addr_t to  
represent the type for both addresses and sizes.

- k