[U-Boot-Users] [PATCH 18/20] [new uImage] Fix build problems on trab board

Wolfgang Denk wd at denx.de
Wed Mar 12 21:55:38 CET 2008


In message <20080312201219.6444.56306.stgit at pollux.denx.de> you wrote:
>
> diff --git a/board/trab/auto_update.c b/board/trab/auto_update.c
> index fa08bff..5311e12 100644
> --- a/board/trab/auto_update.c
> +++ b/board/trab/auto_update.c
> @@ -224,7 +224,7 @@ au_check_cksum_valid(int idx, long nbytes)
>  		return -1;
>  	}
>  	/* check the data CRC */
> -	if (!image_check_dcrc (hdr)) {
> +	if (!image_check_dcrc (hdr))
>  	{

This patch looks broken to me. You should keep the brace on the  same
line  with  the  if,  and rather delete the next line with the single
brace.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Too many people are ready to carry the stool when the piano needs  to
be moved.




More information about the U-Boot mailing list