[U-Boot-Users] [PATCH] cpu/mpc8260/: ported new fdt code from cpu/mpc83xx/

[Wolfgang Denk]

In message <200802251819.19633 at blacky.localdomain> you wrote:
> 
> --- a/cpu/mpc8260/Makefile
> +++ b/cpu/mpc8260/Makefile
> @@ -28,7 +28,7 @@ LIB	= $(obj)lib$(CPU).a
>  START	= start.o kgdb.o
>  COBJS	= traps.o serial_smc.o serial_scc.o cpu.o cpu_init.o speed.o \
>  	  interrupts.o ether_scc.o ether_fcc.o i2c.o commproc.o \
> -	  bedbug_603e.o pci.o spi.o
> +	  bedbug_603e.o pci.o spi.o fdt.o

Maybe we could try and keep (or rather make, s far as possible) lists sorted.

> diff --git a/cpu/mpc8260/fdt.c b/cpu/mpc8260/fdt.c
...
> +	do_fixup_by_compat_u32(blob, "fsl,cpm2-smc-uart",
> +		"current-speed", bd->bi_baudrate, 1);
> +	do_fixup_by_compat_u32(blob, "fsl,cpm2-scc-uart",
> +		"current-speed", bd->bi_baudrate, 1);

I think it is wrong to set both the SMC and the SCC "current-speed" to
the console baudrate. Only one port can be the current console, and
only for this one the value is correct.

Actually I wonder how this is supposed to work at all, as there are
two SMC and 4 SCC which all could be used as UART ports.

Isn't this calling for trouble?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The lesser of two evils -- is evil."             - Seymour (Sy) Leon