[U-Boot-Users] [PATCH] CFI: Small cleanup for FLASH_SHOW_PROGRESS

Jerry Van Baren gerald.vanbaren at ge.com
Wed Mar 19 13:25:55 CET 2008


Stefan Roese wrote:
> With this patch we don't need that many #ifdef's in the code. It moves
> the subtraction into the macro and defines a NOP-macro when
> CONFIG_FLASH_SHOW_PROGRESS is not defined.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
> 
> Jerry, what do you think? If you are ok with to this one, and
> nobody else has some objections, I'll submit both patches.
> 
>  drivers/mtd/cfi_flash.c |   22 +++++++++-------------
>  1 files changed, 9 insertions(+), 13 deletions(-)

Yes, there was that little birdie in the back of my mind saying this 
could be cleaner when I moved the code into the macro and didn't move 
the increment in too (because the increment was different amounts). 
Thanks for chirping louder.  :-)

Acked-by: Gerald Van Baren <vanbaren at cideas.com>




More information about the U-Boot mailing list