[U-Boot-Users] [PATCH 1/7] 83xx: nand support for MPC837XRDB boards

[Kim Phillips]

On Tue, 18 Mar 2008 17:10:55 +0300
Anton Vorontsov <avorontsov at ru.mvista.com> wrote:

> 
> > > -/* VSC7385 Gigabit Switch support */
> > > +/*
> > > + * VSC7385 Gigabit Switch support
> > > + */
> > > +#define CFG_VSC7385_BASE	0xF0000000
> > 
> > What does this have to do with NAND?
> 
> Nothing. I'm expanding VSC7385 comment to better separate it from
> the NAND code. Most lengthy parts of the RDB config are using
> 
> /*
>  *
>  */
> 
> as a logical separator. So did I.

that's fine, it just makes patch review easier and less susceptible to
comments like this if you keep your patches on-subject.

Also, this patch doesn't apply cleanly to the top of
u-boot-mpc83xx.git, because of the VSC7385 patches I applied last week.
Can you rebase your patches to the top of the mpc83xx git tree?  I just
updated it to Wolfgang's top-of-tree.

Kim