[U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function

[Stefan Roese]

On Saturday 22 March 2008, Wolfgang Denk wrote:
> In message <200803220731.23229.sr at denx.de> you wrote:
> > I would prefer to move this init code not into the board code but into
> > the platform/cpu code. Speaking for PPC4xx, here all configuration I know
> > of have the same init code. And copying this into all board ports instead
> > on one place in the cpu directory seems "imperfect".
>
> But the ethernet configuration *is* actually bord dependent. A  board
> may  or  may  not  use  all  the  ethernet  interfaces  present  on a
> processor, or it may have additional network controllers attached for
> example to the PCI bus, etc.

So you vote for adding this code to more than 80 4xx boards that all would use 
the same code here? I don't like this. I would prefer one instance in the cpu 
directory which could be overridden if needed by a board specific version.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================