[U-Boot-Users] [PATCH] DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

[Jean-Christophe PLAGNIOL-VILLARD]

On 12:28 Fri 21 Mar     , Pieter Voorthuijsen wrote:
> 
> 2nd try, previous one was wrapped:
> Double checked spaces and coding style...
> 
> Original message:
> 
> Hello,
> 

>+ * You should have received a copy of the GNU General Public License
>+ * along with this program; if not, write to the Free Software
>+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>+ * MA 02111-1307 USA
>+ */
>+
>+/* This code sets up the timing params for EMIF CE2 and CE3 which
>+ * connect to NOR and NAND flash 
                                 ^
Whitespace please remove
>+ */
Please use this style of comment
/*
 * ....
 * ....
 */
>+ 
  ^
Whitespace please remove
>#include <config.h>
>
>.globl	dv_board_init
>dv_board_init:
>
>extern void	timer_init(void);
>extern int	eth_hw_init(void);
>extern phy_t	phy;
>
>
please remove, only one emply line
>/* Works on Always On power domain only (no PD argument) */
>void lpsc_on(unsigned int id)
>{

>	/* Enable EMAC and AEMIF pins */
>	REG(PINMUX0) = 0x80000c1f;
>
>	/* Enable I2C pin Mux */
>	REG(PINMUX1) |= (1 << 7);
>
>	/* Set the Bus Priority Register to appropriate value */
>	REG(VBPR) = 0x20;
>
>	timer_init();
>
>	return(0);
>}
>
>int misc_init_r (void)
>{
>	int		clk = 0;
>
>	clk = ((REG(PLL2_PLLM) + 1) * 27) / ((REG(PLL2_DIV2) & 0x1f) + 1);
>
>	printf ("ARM Clock : %dMHz\n", ((REG(PLL1_PLLM) + 1) * 27 ) / 2);
>	printf ("DDR Clock : %dMHz\n", (clk / 2));
>
>	if (!eth_hw_init())
>		printf("ethernet init failed!\n");
>	else
>		printf("ETH PHY   : %s\n", phy.name);
>
>
please remove, only one emply line
>	return(0);
>}
>
Best Regards,
J.