[U-Boot-Users] [PATCH] sh: Add support PCI host driver for SH7751/SH7751R

Nobuhiro Iwamatsu iwamatsu at nigauri.org
Sun Mar 23 17:23:41 CET 2008


Hi ,

Thank you for your check.

On Wed, 12 Mar 2008 23:09:50 +0100
Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:

> >  START	= start.o
> >  OBJS	= cpu.o interrupts.o watchdog.o time.o cache.o \
> > -		pci-sh4.o pci-sh7780.o
> > +		pci-sh4.o pci-sh7751.o pci-sh7780.o
> Could you split it to one line for one file
> > +#if defined(CONFIG_PCI) && defined(CONFIG_SH4_PCI) \
> > +	&& defined(CONFIG_SH7751_PCI)
> Could you move it to the Makefile
[snip]
> > +
> > +#include <asm/processor.h>
> > +#include <asm/io.h>
> > +#include <pci.h>
> 
> I think it will be good to move the pci drivers to drivers/pci
OK, I will fix this, send patch .

regards,
 Nobuhiro

-- 
Nobuhiro Iwamatsu
        iwamatsu @ nigauri.org / superh.org / debian.or.jp
	GPG ID : 3170EBE9




More information about the U-Boot mailing list