[U-Boot-Users] [PATCH 1/2] mpc83xx: Add MPC837x PCIE controller RC mode

Jon Loeliger jdl at freescale.com
Tue Mar 25 15:29:04 CET 2008


Markus Klotzbücher wrote:
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> writes:
> 
>>> +
>>> +	reg16 = in_le16(hose_cfg_base + PEX_LTSSM_STAT);
>>> +	if (reg16 < 0x16) {
>>> +		printf("No link\n");
>>> +		hose->indirect_type = INDIRECT_TYPE_NO_PCIE_LINK;
>>> +	} else {
>>> +		printf("link\n");
>>> +	}
>> please remove the bracket on the else
> 
> Come on, this is being ridiculously pedantic.

Absolutely agree.

In my opinion, extra braces should just acceptable
and even encouraged.

jdl






More information about the U-Boot mailing list