[U-Boot-Users] [PATCH v4 0/9] SATA framework and Freescale SATA controller support

[Wolfgang Denk]

Dear Dave,

in message <1206542761.3662.51.camel at localhost.localdomain> you wrote:
> 
> According to your suggestion, I re-spinned the patch series.
> The ata_piix driver is only used by x86 sc520_cdp board, I have not the
> board, so I can not test it. but building/compiling it is passed!

Understood.

> I hope it meet your requirement now.
> please apply it.

I will apply it so we make some progress, but please see comments
below.

> Dave Liu (11):
>       ata: merge the ata_piix driver
>       ata: merge the header of ata_piix driver
>       ata: add the support for SATA framework
>       ata: make the ata_piix driver using new SATA framework
>       ata: add the libata support
>       ata: add the fis struct for SATA
>       ata: enable the sata initialize on boot up
>       ata: add the readme for SATA command line
>       mpc83xx: initialize serdes for MPC837xEMDS boards
>       mpc83xx: enable the SATA interface on mpc837xemds board
>       drivers: add the support for Freescale SATA controller

Applied, but please provide new (incremental) patches to fix the
following remaining issues:

doc/README.sata:

	Please apply Jerry Van Baren's "proposed English polishing."

drivers/block/ata_piix.h:

        Please add a file header which contains appropriate copyright
        and license information.

	Also, please make the file idempotent.

	Also, please change format strings like "49==0x%04x" into
	"49=0x%04x" or "49 = 0x%04x" or (IMHO best) "49 = %04X".
	Please do this globally (some other files, too).

drivers/block/fsl_sata.c:

        Generic S-ATA code like ata_low_level_rw_lba48(),
        ata_low_level_rw_lba28(), sata_read(), sata_write(), or
        scan_sata() is in no way FSL-specific and thus has no place
        in fsl_sata.c; please move this into a separate file.

        I think it would be kind of funny if the sc520 board will
        only compile when fsl_sata.c is included.


Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
                  Nail here --X-- for new monitor.