[U-Boot-Users] [PATCH] Fix warnings introduced by I2C bus speed setting patch

Kumar Gala galak at kernel.crashing.org
Thu Mar 27 00:53:28 CET 2008


Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
---
 drivers/i2c/fsl_i2c.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/fsl_i2c.c b/drivers/i2c/fsl_i2c.c
index dde0571..9f2c1ec 100644
--- a/drivers/i2c/fsl_i2c.c
+++ b/drivers/i2c/fsl_i2c.c
@@ -117,7 +117,6 @@ static unsigned int set_i2c_bus_speed(const struct fsl_i2c *dev,
 {
 	unsigned short divider = min(i2c_clk / speed, (unsigned short) -1);
 	unsigned int i;
-	u8 fdr, dfsr;

 	/*
 	 * We want to choose an FDR/DFSR that generates an I2C bus speed that
@@ -128,15 +127,15 @@ static unsigned int set_i2c_bus_speed(const struct fsl_i2c *dev,

 	for (i = 0; i < ARRAY_SIZE(fsl_i2c_speed_map); i++)
 		if (fsl_i2c_speed_map[i].divider >= divider) {
+			u8 fdr, dfsr;
 			dfsr = fsl_i2c_speed_map[i].dfsr;
 			fdr = fsl_i2c_speed_map[i].fdr;
 			speed = i2c_clk / fsl_i2c_speed_map[i].divider;
+			writeb(fdr, &dev->fdr);		/* set bus speed */
+			writeb(dfsr, &dev->dfsrr);	/* set default filter */
 			break;
 		}

-	writeb(fdr, &dev->fdr);			/* set bus speed */
-	writeb(dfsr, &dev->dfsrr);		/* set default filter */
-
 	return speed;
 }

-- 
1.5.4.1





More information about the U-Boot mailing list