[U-Boot-Users] [PATCH v4 0/9] SATA framework and Freescale SATA controller support

[Dave Liu]

> Applied, but please provide new (incremental) patches to fix the
> following remaining issues:
> 
> doc/README.sata:
> 
>         Please apply Jerry Van Baren's "proposed English polishing."

done.

> drivers/block/ata_piix.h:
> 
>         Please add a file header which contains appropriate copyright
>         and license information.

The original include/sata.h have *not* any copyright and license
information, I think it is better to keep the original state.
so, I don't add the copyright/license info to ata_piix.h

> 
>         Also, please make the file idempotent.
> 
>         Also, please change format strings like "49==0x%04x" into
>         "49=0x%04x" or "49 = 0x%04x" or (IMHO best) "49 = %04X".
>         Please do this globally (some other files, too).

done.

> drivers/block/fsl_sata.c:
> 
>         Generic S-ATA code like ata_low_level_rw_lba48(),
>         ata_low_level_rw_lba28(), sata_read(), sata_write(), or
>         scan_sata() is in no way FSL-specific and thus has no place
>         in fsl_sata.c; please move this into a separate file.

I will do it in next day.

Thanks,
Dave