[U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275
Ben Warren
bwarren at qstreams.com
Sun Mar 30 06:18:15 CEST 2008
Tsi-Chung Liew wrote:
> Signed-off-by: TsiChung Liew <Tsi-Chung.Liew at freescale.com>
> ---
> drivers/net/mcffec.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/mcffec.c b/drivers/net/mcffec.c
> index 3b81258..71d1960 100644
> --- a/drivers/net/mcffec.c
> +++ b/drivers/net/mcffec.c
> @@ -166,6 +166,13 @@ int fec_send(struct eth_device *dev, volatile void *packet, int length)
> /* Activate transmit Buffer Descriptor polling */
> fecp->tdar = 0x01000000; /* Descriptor polling active */
>
> + /* FEC fix for MCF5275, FEC unable to initial transmit data packet.
> + * A nop will ensure the descriptor polling active completed.
> + */
> +#ifdef CONFIG_M5275
> + __asm__ ("nop");
> +#endif
> +
> #ifdef CFG_UNIFY_CACHE
> icache_invalid();
> #endif
>
Applied to net tree. As others have noted, adding a NOP here seems like
a band-aid, but I can't really dispute it.
thanks,
Ben
More information about the U-Boot
mailing list