[U-Boot-Users] [PATCH] Merge code duplication in ata.h and libata.h

[Dave Liu]

> -       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_SIZE * blkcnt);
> +       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_BYTESIZE * blkcnt);
>         return blkcnt;
>  }
> 
> @@ -658,7 +659,7 @@ static u32 fsl_sata_rw_cmd_ext(int dev, u32 start,
> u32 blkcnt, u8 *buffer, int i
>         cfis->sector_count_exp = (blkcnt >> 8) & 0xff;
>         cfis->sector_count = blkcnt & 0xff;
> 
> -       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_SIZE * blkcnt);
> +       fsl_sata_exec_cmd(sata, cfis, CMD_ATA, 0, buffer,
> ATA_SECT_BYTESIZE * blkcnt);
>         return blkcnt;


Nack.

Don't do this.

I don't think the ATA_SECT_BYTESIZE is better than
the ATA_SECT_SIZE.

The libata.h is closely than the latest linux kernel.