[U-Boot-Users] [PATCH] Merge code duplication in ata.h and libata.h

[Wolfgang Denk]

In message <MdNGBCPY.1206951652.2688260.tor at localhost> you wrote:
> 
> >I don't think the ATA_SECT_BYTESIZE is better than
> >the ATA_SECT_SIZE.

Actually it's worse.

> The big problem here is that ata.h defines ATA_SECT_SIZE as 256 Words
> where libata defines it as 512 Bytes.

But "BYTESIZE" reads to me as "size of byte", just as if ATA sectors
used something different than 8 bits per byte.

If you need such a new definition, then please call it different.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Love sometimes expresses itself in sacrifice.
	-- Kirk, "Metamorphosis", stardate 3220.3