[U-Boot-Users] [PATCH] ColdFire: Get information from the correct GCC

Wolfgang Denk wd at denx.de
Sat May 3 23:11:26 CEST 2008


In message <48193C37.6030106 at ruby.dti.ne.jp> you wrote:
>
> >  PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
> > -ifeq ($(findstring 4.2,$(shell $(CC) --version)),4.2)
> > +ifeq ($(findstring 4.2,$(shell $(CROSS_COMPILE)gcc --version)),4.2)
> >  PLATFORM_CPPFLAGS += -mcpu=5208 -fPIC
> >  else
> >  PLATFORM_CPPFLAGS += -m5307 -fPIC
> 
> Let me make sure the intention of this change. With or without this
> change, we can always evaluate $(CROSS_COMPILE)gcc --version, right?
> Or am I missing something?
> 
> There are several $(CC)/$(AR)/$(AS)/$(CPP) users in cpu/*/Makefile &
> cpu/*/config.mk. I'm wondering whether we need to fix all these usages
> or not.

The thing is, that all the $(CC)/$(AR)/$(AS)/$(CPP) definitions are
fine as when used during the build process; but we have a bug when
using them in the initial steps while generating the "make" parameters
and variable settings - the bug is in config.mk which includes
cpu/*/config.mk *before* $(CC)/$(AR)/$(AS)/$(CPP) get set.

I will post a patch for this; it replaces this commit:

	commit b7166e05a513c0806b63b9dfb6f1d77645cede2a
	Author: TsiChung Liew <Tsi-Chung.Liew at freescale.com>
	Date:   Wed Apr 30 12:10:23 2008 -0500

	    ColdFire: Get information from the correct GCC

which I'm going to revert when the patch gets applied.

These changes have already been applied to the u-boot-testing
repository, see
http://git.denx.de/?p=u-boot/u-boot-testing.git;a=summary

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That was the thing about deserts. They had their  own  gravity.  They
sucked you into the centre.           - Terry Pratchett, _Small Gods_




More information about the U-Boot mailing list