[U-Boot-Users] [PATCH 13/21] Remeber the 0013-Remeber-the-RAM-and-NAND-detected-sizes-for-later-di.patch

[Stelian Pop]

Le mardi 06 mai 2008 à 21:28 +0200, Wolfgang Denk a écrit :
> In message <1210088022-25757-14-git-send-email-stelian at popies.net> you wrote:
> > 
> > Signed-off-by: Stelian Pop <stelian at popies.net>
> > ---
> >  include/asm-arm/u-boot.h |    4 ++++
> >  lib_arm/board.c          |   14 ++++++++------
> >  2 files changed, 12 insertions(+), 6 deletions(-)
> > 
> > diff --git a/include/asm-arm/u-boot.h b/include/asm-arm/u-boot.h
> > index c120312..dbfe2cf 100644
> > --- a/include/asm-arm/u-boot.h
> > +++ b/include/asm-arm/u-boot.h
> > @@ -48,10 +48,14 @@ typedef struct bd_info {
> >  	ulong start;
> >  	ulong size;
> >      } 			bi_dram[CONFIG_NR_DRAM_BANKS];
> > +    ulong		bi_dram_size;
> 
> Why would that be needed?  Isn't  adding  the  "size"  entries  above
> sufficient?

It is. But this addition is done once more in the LCD driver (see patch
14/21), so I thought it would be useful to remember the result.

But if you consider it's more costly to add 4 bytes in global data than
to do the addition again, I can change it back.

-- 
Stelian Pop <stelian at popies.net>