[U-Boot-Users] [PATCH 09/21] AT91SAM9261EK support

[Stelian Pop]

Le mardi 06 mai 2008 à 21:33 +0200, Wolfgang Denk a écrit :

> > diff --git a/board/atmel/at91sam9261ek/u-boot.lds b/board/atmel/at91sam9261ek/u-boot.lds
> > new file mode 100644
> > index 0000000..05a6d83
> > --- /dev/null
> > +++ b/board/atmel/at91sam9261ek/u-boot.lds
> > @@ -0,0 +1,57 @@
> > +/*
> > + * (C) Copyright 2002
> > + * Gary Jennejohn, DENX Software Engineering, <gj <at> denx.de>
> 
> Please add your own (C), and don't meddle with Gary's.

I did not modify this file, merely copied it verbatim from
board/atmel/at91cap9adk, which in turn was copied from
board/atmel/at91rm9200dk. So I see no reason to add my own copyright.

As for the mangle, see my other mail on the subject.

> > diff --git a/include/asm-arm/arch-at91sam9/at91sam9261.h b/include/asm-arm/arch-at91sam9/at91sam9261.h
> > new file mode 100644
> > index 0000000..c7c4778
> > --- /dev/null
> > +++ b/include/asm-arm/arch-at91sam9/at91sam9261.h
> > @@ -0,0 +1,105 @@
> > +/*
> > + * include/asm-arm/arch-at91/at91sam9261.h
> > + *
> > + * Copyright (C) SAN People
> 
> Who exactly is "SAN People" ?

The at91sam9261.h and at91sam9261_matrix.h are verbatim copies of the
header files of the Linux kernel.

For example:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=include/asm-arm/arch-at91/at91sam9261.h;h=c7c4778dac49bed468e44eab6a23a32dd468789a;hb=HEAD

> > diff --git a/include/asm-arm/arch-at91sam9/at91sam9261_matrix.h b/include/asm-arm/arch-at91sam9/at91sam9261_matrix.h
> > new file mode 100644
> > index 0000000..6f07242
> > --- /dev/null
> > +++ b/include/asm-arm/arch-at91sam9/at91sam9261_matrix.h
> > @@ -0,0 +1,62 @@
> > +/*
> > + * include/asm-arm/arch-at91/at91sam9261_matrix.h
> > + *
> > + * Memory Controllers (MATRIX, EBI) - System peripherals registers.
> > + * Based on AT91SAM9261 datasheet revision D.
> 
> (C) missing.

ditto.

> 
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> > +
> > +#ifndef AT91SAM9261_MATRIX_H
> > +#define AT91SAM9261_MATRIX_H
> > +
> > +#define AT91_MATRIX_MCFG	(AT91_MATRIX + 0x00)	/* Master Configuration Register */
> > +#define		AT91_MATRIX_RCB0	(1 << 0)		/* Remap Command for AHB Master 0 (ARM926EJ-S Instruction Master) */
> > +#define		AT91_MATRIX_RCB1	(1 << 1)		/* Remap Command for AHB Master 1 (ARM926EJ-S Data Master) */

> Line length!!!

No, I won't change this one. For maintenance reasons it is better to
keep it identical to the kernel file.

Stelian.
-- 
Stelian Pop <stelian at popies.net>