[U-Boot-Users] [PATCH 09/21] AT91SAM9261EK support

[Stelian Pop]

Le mardi 06 mai 2008 à 23:14 +0200, Wolfgang Denk a écrit :
> In message <1210105131.25356.61.camel at galileo> you wrote:
> > 
> > > > + * (C) Copyright 2002
> > > > + * Gary Jennejohn, DENX Software Engineering, <gj <at> denx.de>
> > > 
> > > Please add your own (C), and don't meddle with Gary's.
> > 
> > I did not modify this file, merely copied it verbatim from
> > board/atmel/at91cap9adk, which in turn was copied from
> > board/atmel/at91rm9200dk. So I see no reason to add my own copyright.
> 
> If it's just copuied without changes, it's time to factor it out.

Isn't every board supposed to have a u-boot.lds file ? How could I
factor these out ?
> 
> > As for the mangle, see my other mail on the subject.
> 
> Understood, but needs to be fixed.

I'll submit a patch for this.

> > > > + * Copyright (C) SAN People
> > > 
> > > Who exactly is "SAN People" ?
> > 
> > The at91sam9261.h and at91sam9261_matrix.h are verbatim copies of the
> > header files of the Linux kernel.
> 
> This explains where the file is coming from, but does not  answer  my
> question.

I think SAN is the former employer of Andrew Victor, the AT91 kernel
maintainer.

> > > > +++ b/include/asm-arm/arch-at91sam9/at91sam9261_matrix.h
> > > > @@ -0,0 +1,62 @@
> > > > +/*
> > > > + * include/asm-arm/arch-at91/at91sam9261_matrix.h
> > > > + *
> > > > + * Memory Controllers (MATRIX, EBI) - System peripherals registers.
> > > > + * Based on AT91SAM9261 datasheet revision D.
> > > 
> > > (C) missing.
> > 
> > ditto.
> 
> Maybe. It's still missing.

And what am I supposed to do ? 

-- 
Stelian Pop <stelian at popies.net>