[U-Boot-Users] [PATCH] Propagate Error Status to the Shell on fw_printenv Errors

[Markus Klotzbücher]

Dear Grant,

Grant Erickson <gerickson at nuovations.com> writes:

> Thanks for the comments. As suggested by Wolfgang, the "-n" option was
> pre-existing in the code before my patch.
>
> I can investigate extending "-n" as described above; however, the caveat is
> that the user knows that the values of some variables may have spaces. In
> such a case, he/she might find the above example to not work as expected.

Thats right, but then that's a problem the user needs to be aware of.

> Anyway, hopefully Wolfgang can ACK the patch as is and I can look at
> extending the "-n" option as another separate effort.

Ok, fine!

> PS: To which documentation are you referring? The comments in the source or
> the DULG?

The README in the tools/env/ directory. As you're fixing a bug (opposed
to adding a feature) there's no obligation really to do this, but it
would be great anyway :-)

And I can take care of updating the DULG.

Thanks!

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de