[U-Boot-Users] [PATCH v2 1/3] New i.MX31 SPI driver

[Wolfgang Denk]

In message <Pine.LNX.4.64.0805082103120.8518 at axis700.grange> you wrote:
> 
> > > > Of course, your solution will work with multiple, different SPI
> > > > controllers while mine won't, but is that really necessary?
> > > > 
> > > > Your solution comes with more error checking as well, which might be a
> > > > good thing, but since it comes with a cost of additional memory and
> > > > flash footprint, I think it should be optional. Maybe we could provide
> > > > some library functions to simplify the drivers that want this?
> > > 
> > > I see. Well, I don't have a strong preference. So, either we need more 
> > > votes, or the one who implements it decides:-)
> > 
> > That was two pros - did I miss any cons ?
> 
> I think, those were two pros - but for two somewhat different solutions.

Oops?

"your solution will work with multiple, different SPI controllers" and
"Your solution comes with more error checking as well"
seem to me as if it were 2 x pro for your code.

Am I missing something?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What's the sound a name makes when it's dropped?