[U-Boot-Users] [PATCH] Remove $(VERSION_FILE) from PHONY Target List

Wolfgang Denk wd at denx.de
Fri May 9 10:22:46 CEST 2008


In message <C42519C4.E8EE%gerickson at nuovations.com> you wrote:
> When building against non-local, non-disk-backed file systems (e.g. NFS,
> tmpfs), the u-boot build can iterate forever, attempting to re-generate
> "include/autoconf.mk". This occurs because $(VERSION_FILE) (aka
> ${ROOT}/u-boot/build/include/version_autogenerated.h) is always regarded as
> out-of-date because it is in the .PHONY target list, even though it's a real
> file and seems to need to be only created once and only once.
> 
> This patch removes $(VERSION_FILE) from the .PHONY target list and has been
> verified to work with various flavors and builds of make-3.81 against NFS,
> ext2fs, ext3fs and tmpfs file systems.
> 
> More detail at:
> 
> http://sourceforge.net/mailarchive/message.php?msg_id=C4180895.E556%25gerick
> son%40nuovations.com

This may fix your immediate problem, but it is wrong. Assume you have
built U-Boot from some specific version, then the git commit ID  will
be  shown  as  part of the version string. Assume you now edit a file
and run "make" again. The intention is that this new build shows  the
"-dirty" marker in the version string, plus the new build date.

Your change breaks this behaviour.

I just  posted  another  patch:  ``Avoid  infinite  loop  "Generating
include/autoconf.mk" '' which is supposed to fix the problem, without
unwanted side effects.

Please test.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The more data I punch in this card,  the lighter it becomes, and the
lower the mailing cost."
                     - Stan Kelly-Bootle, "The Devil's DP Dictionary"




More information about the U-Boot mailing list