[U-Boot-Users] [PATCH 2/4 V2] PPC: Change lib_ppc/bat_rw.c to use high bats

Becky Bruce Becky.bruce at freescale.com
Fri May 9 20:41:58 CEST 2008


On May 9, 2008, at 10:28 AM, Scott Wood wrote:
> On Thu, May 08, 2008 at 07:02:23PM -0500, Becky.bruce at freescale.com  
> wrote:
>> diff --git a/include/asm-ppc/mmu.h b/include/asm-ppc/mmu.h
>> index 49d6860..f836270 100644
>> --- a/include/asm-ppc/mmu.h
>> +++ b/include/asm-ppc/mmu.h
>> @@ -141,6 +141,10 @@ extern void _tlbia(void);		/* invalidate all  
>> TLB entries */
>> typedef enum {
>> 	IBAT0 = 0, IBAT1, IBAT2, IBAT3,
>> 	DBAT0, DBAT1, DBAT2, DBAT3
>> +#ifdef CONFIG_HIGH_BATS
>> +	, IBAT4, IBAT5, IBAT6, IBAT7,
>> +	DBAT4, DBAT5, DBAT6, DBAT7
>> +#endif
>
> C allows trailing commas on such lists; no need to move it inside the
> ifdef.

Dangling commas bother me in the extreme.  If this is the concensus,  
I'll move it, but I prefer it where it is.

-B





More information about the U-Boot mailing list