[U-Boot-Users] [PATCH] mx31ads: fix 32kHz clock handling

Wolfgang Denk wd at denx.de
Sat May 10 00:21:36 CEST 2008


In message <Pine.LNX.4.64.0805080953480.3212 at axis700.grange> you wrote:
> According to schematics and to RedBoot sources, the MX31ADS uses a 32768Hz 
> oscillator as a SKIL source. Fix previously wrongly assumed 32000Hz value. 
> Also fix a typo when verifying a jumper configuration. While at it, make 
> two needlessly global functions static.
> 
> Signed-off-by: Guennadi Liakhovetski <lg at denx.de>

Applied for now, but...

> -#define CFG_HZ			32000
> +#define CFG_HZ			CONFIG_MX31_CLK32 /* use 32kHz clock as source */

...note that this is broken.


CFG_HZ shall always be 1000.  Consider it a constant, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
[Braddock:] Mr. Churchill, you are drunk.
[Churchill:] And you madam, are ugly.  But I shall be sober tomorrow.




More information about the U-Boot mailing list