[U-Boot-Users] [PATCH 2/2] Added support for Aztek Networks cta5000s telecom board.

[Wolfgang Denk]

In message <1210781443-6819-3-git-send-email-jblack at azteknetworks.com> you wrote:
> ---
>  board/cta5000s/Makefile    |   50 +++
>  board/cta5000s/config.mk   |   30 ++
>  board/cta5000s/cta5000s.c  |  575 +++++++++++++++++++++++++++++++++++
>  include/configs/cta5000s.h |  723 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 1378 insertions(+), 0 deletions(-)
>  create mode 100644 board/cta5000s/Makefile
>  create mode 100644 board/cta5000s/config.mk
>  create mode 100644 board/cta5000s/cta5000s.c
>  create mode 100644 include/configs/cta5000s.h

There is trailing white space in some of the files.

Please use TABs for indentation instead of spaces (Not only at the
beginning of the lines).

> +/* See include/configs/cta5000s.h for CFG_* settings
> + * All values in the following tables taken from
> + * chapter 6 of the cta Programmer's Guide
> + */
...
> +/* Compact Flash Control Registers
> + */
...
> +/* Compact Flash IO memory
> + */

These comments, and many others, are not in the requested format for
multiline comments.

And I dare to ask if this:

> +/* FPGA memory 
> + */

really requires a multiline comment? 


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The more we disagree, the more chance there is that at least  one  of
us is right.