[U-Boot-Users] [PATCH 1/1] Fix 8313ERDB board configuration

[Ben Warren]

York Sun wrote:
> Ben,
>
> On Thu, 2008-05-15 at 13:50 -0700, Ben Warren wrote:
>   
>>> -#ifdef CONFIG_HAS_ETH0
>>>  #define CONFIG_ETHADDR		00:E0:0C:00:95:01
>>> -#endif
>>> -
>>> -#ifdef CONFIG_HAS_ETH1
>>>  #define CONFIG_ETH1ADDR		00:E0:0C:00:95:02
>>> -#endif
>>>   
>>>       
>> Please also remove the default MAC address assignments.
>>     
>
> I think we need them, don't we?
>
>   
No, there have been many discussions about this, and the consensus is 
that there shouldn't be default addresses assigned.  One of many reasons 
is that the numbers you've chosen actually belong to some kind of 
corporate entity (I would guess Freescale) and not the end user.  It's 
better for the end user to either use private addresses or ones that 
they have purchased from IEEE.
>>>  
>>>  #define CONFIG_IPADDR		10.0.0.2
>>>  #define CONFIG_SERVERIP		10.0.0.1
>>>   
>>>       
>> While you're at it, putting default IP addresses is also pointless.
>>     
>
> At least it tells you that you can put your address here. It doesn't
> hurt.
> And BTW, I want to make my patch as small as possible. I'll leave the
> rest to the board maintainer.
>
> York
>
>
>   
I'm less picky about this one because as you say it doesn't really 
hurt.  All it will do is initialize the network to an unreachable state 
on the vast majority of purchasers of your eval boards.  Let's leave it 
up to the board maintainer.

regards,
Ben