[U-Boot-Users] [PATCH 1/1] Fix 8313ERDB board configuration

[Timur Tabi]

Wolfgang Denk wrote:
> In message <1210886469.880.45.camel at laptop> you wrote:
>>> Please also remove the default MAC address assignments.
>> I think we need them, don't we?
> 
> No, or you can install this U-Boot image exactly on one specific,
> single board.

I understand your argument, but it's rather disingenuous when you allow this
code to exist:

#ifdef	CONFIG_ETHADDR
	"ethaddr="	MK_STR(CONFIG_ETHADDR)		"\0"
#endif
#ifdef	CONFIG_ETH1ADDR
	"eth1addr="	MK_STR(CONFIG_ETH1ADDR)		"\0"
#endif
#ifdef	CONFIG_ETH2ADDR
	"eth2addr="	MK_STR(CONFIG_ETH2ADDR)		"\0"
#endif
#ifdef	CONFIG_ETH3ADDR
	"eth3addr="	MK_STR(CONFIG_ETH3ADDR)		"\0"
#endif
#ifdef	CONFIG_IPADDR
	"ipaddr="	MK_STR(CONFIG_IPADDR)		"\0"
#endif
#ifdef	CONFIG_SERVERIP
	"serverip="	MK_STR(CONFIG_SERVERIP)		"\0"
#endif

If you get rid of this block, you'll solve the problem for all boards, instead
of nagging people who post patches for unrelated bugs.

-- 
Timur Tabi
Linux kernel developer at Freescale