[U-Boot-Users] Duplicate implementations of testdram() deprecated

Wolfgang Denk wd at denx.de
Sun May 18 22:17:46 CEST 2008


Hello,

I just noticed that 84  boards  contain  some  function  "testdram()"
which  (and I guess few people are surprised) in 80+ cases is basicly
a verbatim copy of the same code.

Allt hese boards completely  ignore  that  we  already  have  several
implamentations  of  memory  test code both in the mtest command (see
"common/cmd_mem.c") and in the  POST  (see  "post/drivers/memory.c").
depending  on  requirements  these can be selected / configured to be
either faster or more thorough.


I hereby ask the maintainers of the  following  boards  to  clean  up
theirt  code  and  get  rid of the duplicated code. Please remove the
"testdram()" implementation (which is disabled in all  but  6  boards
anyway)  from  your code and use for example the respective POST code
instead:


board/BuS/EB+MCF-EV123/EB+MCF-EV123.c
board/Marvell/db64360/db64360.c
board/Marvell/db64460/db64460.c
board/amcc/bamboo/bamboo.c
board/amcc/bubinga/bubinga.c
board/amcc/ebony/ebony.c
board/amcc/luan/luan.c
board/amcc/ocotea/ocotea.c
board/amcc/sequoia/sequoia.c
board/amcc/walnut/walnut.c
board/amcc/yosemite/yosemite.c
board/amcc/yucca/yucca.c
board/amcc/acadia/memory.c
board/amcc/katmai/katmai.c
board/amcc/taihu/taihu.c
board/amcc/taishan/taishan.c
board/amcc/kilauea/memory.c
board/amcc/makalu/memory.c
board/amcc/canyonlands/canyonlands.c
board/cobra5272/cobra5272.c
board/cray/L1/L1.c
board/dave/PPChameleonEVB/PPChameleonEVB.c
board/eric/eric.c
board/esd/adciop/adciop.c
board/esd/ar405/ar405.c
board/esd/canbt/canbt.c
board/esd/cpci750/cpci750.c
board/esd/cpciiser4/cpciiser4.c
board/esd/dasa_sim/dasa_sim.c
board/esd/dp405/dp405.c
board/esd/du405/du405.c
board/esd/ocrtc/ocrtc.c
board/esd/pci405/pci405.c
board/esd/tasreg/tasreg.c
board/esd/voh405/voh405.c
board/fads/fads.c
board/g2000/g2000.c
board/gw8260/gw8260.c
board/idmr/idmr.c
board/jse/sdram.c
board/sbc8641d/sbc8641d.c
board/m5271evb/m5271evb.c
board/m5272c3/m5272c3.c
board/ml2/ml2.c
board/freescale/m5235evb/m5235evb.c
board/freescale/m5249evb/m5249evb.c
board/freescale/m5253evbe/m5253evbe.c
board/freescale/m5329evb/m5329evb.c
board/freescale/m54455evb/m54455evb.c
board/freescale/mpc8544ds/mpc8544ds.c
board/freescale/mpc8641hpcn/mpc8641hpcn.c
board/freescale/mpc8540ads/mpc8540ads.c
board/freescale/mpc8541cds/mpc8541cds.c
board/freescale/mpc8548cds/mpc8548cds.c
board/freescale/mpc8555cds/mpc8555cds.c
board/freescale/mpc8560ads/mpc8560ads.c
board/freescale/mpc8568mds/mpc8568mds.c
board/freescale/mpc8610hpcd/mpc8610hpcd.c
board/freescale/mpc837xerdb/mpc837xerdb.c
board/freescale/m52277evb/m52277evb.c
board/freescale/m5373evb/m5373evb.c
board/freescale/m547xevb/m547xevb.c
board/freescale/m548xevb/m548xevb.c
board/freescale/m5275evb/m5275evb.c
board/mpc8540eval/mpc8540eval.c
board/korat/korat.c
board/mpl/common/memtst.c
board/lwmon5/lwmon5.c
board/pcs440ep/pcs440ep.c
board/pm854/pm854.c
board/pm856/pm856.c
board/prodrive/alpr/alpr.c
board/prodrive/p3mx/p3mx.c
board/sandburst/common/sb_common.c
board/sbc405/sbc405.c
board/sbc8560/sbc8560.c
board/stxgp3/stxgp3.c
board/tqm85xx/sdram.c
board/xilinx/ml300/ml300.c
board/xpedite1k/xpedite1k.c
board/stxssa/stxssa.c
board/zeus/zeus.c
board/atum8548/atum8548.c
board/sbc8548/sbc8548.c


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
ADVISORY:  There is  an  Extremely Small  but  Nonzero  Chance  That,
Through a Process Know as "Tunneling," This Product May Spontaneously
Disappear  from Its Present Location and Reappear at Any Random Place
in the Universe, Including Your Neighbor's Domicile. The Manufacturer
Will Not Be Responsible for Any Damages  or  Inconvenience  That  May
Result.




More information about the U-Boot mailing list