[U-Boot-Users] [PATCH 06/17] ds1722: Fix mutliple warnings and errors and active the ssi for SC520 boards

Wolfgang Denk wd at denx.de
Mon May 19 00:39:29 CEST 2008


In message <1211130599-28289-7-git-send-email-plagnioj at jcrosoft.com> you wrote:
> ds1722.c:6:17: error: ssi.h: No such file or directory
> ds1722.c:6:17: error: ssi.h: No such file or directory
> cc1: warnings being treated as errors
> ds1722.c: In function 'ds1722_select':
> ds1722.c:10: warning: implicit declaration of function 'ssi_set_interface'
> ds1722.c:11: warning: implicit declaration of function 'ssi_chip_select'
> ds1722.c: In function 'ds1722_read':
> ds1722.c:24: warning: implicit declaration of function 'ssi_tx_byte'
> ds1722.c:25: warning: implicit declaration of function 'ssi_rx_byte'
> ds1722.c: In function 'ds1722_probe':
> ds1722.c:137: error: 'DS1722_RESOLUTION_12BIT' undeclared (first use in this function)
> ds1722.c:137: error: (Each undeclared identifier is reported only once
> ds1722.c:137: error: for each function it appears in.)

Please do NOT include such long lists of error messages into the
commit message. Thanks.


> --- /dev/null
> +++ b/include/ds1722.h
> @@ -0,0 +1,32 @@
> +/*
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA

Copyright entry missing.

> --- /dev/null
> +++ b/include/ssi.h
> @@ -0,0 +1,29 @@
> +/*
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */

Copyright entry missing.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The nice thing about  standards  is that there are  so many to choose
from.                                           - Andrew S. Tanenbaum




More information about the U-Boot mailing list