[U-Boot-Users] [PATCH 17/17] sc520_cdp: Fix multiple warnings

Wolfgang Denk wd at denx.de
Mon May 19 01:00:22 CEST 2008


In message <1211130599-28289-18-git-send-email-plagnioj at jcrosoft.com> you wrote:
> sc520_cdp.c: In function 'pci_sc520_cdp_fixup_irq':
> sc520_cdp.c:134: warning: pointer targets in passing argument 4 of 'pci_hose_read_config_byte' differ in signedness
> sc520_cdp.c: In function 'spi_read':
> sc520_cdp.c:598: warning: pointer targets in passing argument 3 of 'spi_eeprom_read' differ in signedness
> sc520_cdp.c: In function 'spi_write':
> sc520_cdp.c:622: warning: pointer targets in passing argument 3 of 'spi_eeprom_write' differ in signedness
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  board/sc520_cdp/sc520_cdp.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/board/sc520_cdp/sc520_cdp.c b/board/sc520_cdp/sc520_cdp.c
> index f6f0e72..9828024 100644
> --- a/board/sc520_cdp/sc520_cdp.c
> +++ b/board/sc520_cdp/sc520_cdp.c
> @@ -128,7 +128,7 @@ static void pci_sc520_cdp_fixup_irq(struct pci_controller *hose, pci_dev_t dev)
>  	};
>  	static int next_irq_index=0;
>  
> -	char tmp_pin;
> +	u8 tmp_pin;

Please use uchar here, too.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every program has at least one bug and can be shortened by  at  least
one  instruction  --  from  which,  by induction, one can deduce that
every program can be reduced to one instruction which doesn't work.




More information about the U-Boot mailing list