[U-Boot-Users] [PATCH][resubmit] MPC85xx, MPC83xx: Add/Fix UPM configuration support

Jerry Van Baren gerald.vanbaren at ge.com
Mon May 19 21:32:22 CEST 2008


David Saada wrote:
> Add support for UPM configuration on the 85xx platform.
> In addition, on the MPC83xx, remove MPC834x precompiler condition, in 
> order to support all MPC83xx processors.
>  
> Signed-off-by: David Saada <david.saada at ecitele.com>

Bad news, David, I think I mislead you with my Option #1 - it looks 
sorta OK, but it still is full of bad stuff, including line wraps, when 
you look at the actual text of the email.

This is a snippet of the email source (text version, the HTML version is 
not even worth pasting in)

> cpu/mpc83xx/cpu.c |    5 ----
> cpu/mpc85xx/cpu.c |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++=
> ++++
> include/mpc85xx.h |    7 ++++-
> 3 files changed, 72 insertions(+), 6 deletions(-)
> 
> --- a/cpu/mpc83xx/cpu.c 2008-05-15 01:42:46.000000000 +0300
> +++ b/cpu/mpc83xx/cpu.c 2008-05-18 11:22:34.503036000 +0300
> @@ -147,7 +147,6 @@ int checkcpu(void)
>   */
>  void upmconfig (uint upm, uint *table, uint size)
>  {
> -#if defined(CONFIG_MPC834X)
>         volatile immap_t *immap =3D (immap_t *) CFG_IMMR;
>         volatile lbus83xx_t *lbus =3D &immap->lbus;
>         volatile uchar *dummy =3D NULL;
> @@ -180,10 +179,6 @@ void upmconfig (uint upm, uint *table, u
> 
>         /* Set the OP field in the MxMR to "normal" and the MAD field to 00=
> 0000 */

Note the above is linewrapped with quoted printable "stuff" in it.

>         *mxmr &=3D 0xCFFFFFC0;

The =3D is more quoted printable "stuff."

> -#else
> -       printf("Error: %s() not defined for this configuration.\n", __FUNCT=
> ION__);

More line wrapped q-p "stuff."

> -       hang();
> -#endif
>  }

Sorry for getting your hopes up.  Try finding an open port 25.  :-/

Best regards,
gvb




More information about the U-Boot mailing list